]> git.baikalelectronics.ru Git - kernel.git/commit
spi: xlp: fix error return code in xlp_spi_probe()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 8 Aug 2017 04:45:02 +0000 (23:45 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 8 Aug 2017 10:36:07 +0000 (11:36 +0100)
commit4cd8966d06b16cebe957656f80e60ea8ce2ad5ee
tree15be0a96b480bf376add9e5138d176c454d55f5e
parent9238ecfbaaeffcf7977c2776af9c57c0a4a878ed
spi: xlp: fix error return code in xlp_spi_probe()

platform_get_irq() returns an error code, but the spi-xlp driver ignores
it and always returns -EINVAL. This is not correct and, prevents
-EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f9ecb1c203866dddb5f0f89842ac73f6df9b4033

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-xlp.c