]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2090cc3) | patch
ALSA: USB: 6fire: signedness bug in usb6fire_pcm_prepare()
authorDan Carpenter <error27@gmail.com>
Mon, 7 Feb 2011 17:25:19 +0000 (20:25 +0300)
committerTakashi Iwai <tiwai@suse.de>
Mon, 7 Feb 2011 17:30:10 +0000 (18:30 +0100)
commit4c86cf368c839e794090b4a53c9ea52a30aa70ca
treeb256c95edfa535ab4d33dc8411a332334f2b5df4tree | snapshot
parent2090cc379a7166bddf5d88701d62af60a242ab82commit | diff
ALSA: USB: 6fire: signedness bug in usb6fire_pcm_prepare()

rt->rate is an unsigned char so it's never equal to -1.  It's not a huge
problem because the invalid rate is caught inside the call to
usb6fire_pcm_set_rate() which returns -EINVAL.  But if we fix the test
then it prints out the correct error message so that's good.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/6fire/pcm.c diff | blob | history
Linux Kernel Source Tree.