]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: nf_conntrack_ftp: Fix debug output
authorThomas Jarosch <thomas.jarosch@intra2net.com>
Wed, 21 Aug 2019 14:14:28 +0000 (16:14 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 27 Aug 2019 11:01:05 +0000 (13:01 +0200)
commit4c438baf17560df566e4c0d8cf6aa9f2375cceb9
tree3d488e7595c0def921e70af3fdeafdacdf6c1466
parent675cd3743e7664fe80b8bef82f92bc8279b39396
netfilter: nf_conntrack_ftp: Fix debug output

The find_pattern() debug output was printing the 'skip' character.
This can be a NULL-byte and messes up further pr_debug() output.

Output without the fix:
kernel: nf_conntrack_ftp: Pattern matches!
kernel: nf_conntrack_ftp: Skipped up to `<7>nf_conntrack_ftp: find_pattern `PORT': dlen = 8
kernel: nf_conntrack_ftp: find_pattern `EPRT': dlen = 8

Output with the fix:
kernel: nf_conntrack_ftp: Pattern matches!
kernel: nf_conntrack_ftp: Skipped up to 0x0 delimiter!
kernel: nf_conntrack_ftp: Match succeeded!
kernel: nf_conntrack_ftp: conntrack_ftp: match `172,17,0,100,200,207' (20 bytes at 4150681645)
kernel: nf_conntrack_ftp: find_pattern `PORT': dlen = 8

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_ftp.c