]> git.baikalelectronics.ru Git - kernel.git/commit
crypto: qcom-rng - fix infinite loop on requests not multiple of WORD_SZ
authorOndrej Mosnacek <omosnace@redhat.com>
Tue, 3 May 2022 11:50:10 +0000 (13:50 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 13 May 2022 09:13:38 +0000 (17:13 +0800)
commit4c21367a630c3388e3fe0ffdbaac18d5a00be934
tree98f5120103939452b502be443346d5c49523ba3a
parentdbb008736a8c113ef1e12b4e4b4351fac2a15ede
crypto: qcom-rng - fix infinite loop on requests not multiple of WORD_SZ

The commit referenced in the Fixes tag removed the 'break' from the else
branch in qcom_rng_read(), causing an infinite loop whenever 'max' is
not a multiple of WORD_SZ. This can be reproduced e.g. by running:

    kcapi-rng -b 67 >/dev/null

There are many ways to fix this without adding back the 'break', but
they all seem more awkward than simply adding it back, so do just that.

Tested on a machine with Qualcomm Amberwing processor.

Fixes: 0b84cc29748e ("crypto: qcom-rng - ensure buffer for generate is completely filled")
Cc: stable@vger.kernel.org
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/qcom-rng.c