]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/xive: Fix bogus error code returned by OPAL
authorGreg Kurz <groug@kaod.org>
Wed, 11 Sep 2019 15:52:18 +0000 (17:52 +0200)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 11 Sep 2019 23:27:05 +0000 (09:27 +1000)
commit4c1f0fc8710c044605786c3b5f76adf356b116fb
treee2680d33f9b4590f7e3ecf70c7af8310a333d433
parentf0c51121b9c12350d345be4322a7faa74618feed
powerpc/xive: Fix bogus error code returned by OPAL

There's a bug in skiboot that causes the OPAL_XIVE_ALLOCATE_IRQ call
to return the 32-bit value 0xffffffff when OPAL has run out of IRQs.
Unfortunatelty, OPAL return values are signed 64-bit entities and
errors are supposed to be negative. If that happens, the linux code
confusingly treats 0xffffffff as a valid IRQ number and panics at some
point.

A fix was recently merged in skiboot:

e97391ae2bb5 ("xive: fix return value of opal_xive_allocate_irq()")

but we need a workaround anyway to support older skiboots already
in the field.

Internally convert 0xffffffff to OPAL_RESOURCE which is the usual error
returned upon resource exhaustion.

Cc: stable@vger.kernel.org # v4.12+
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/156821713818.1985334.14123187368108582810.stgit@bahia.lan
arch/powerpc/include/asm/opal.h
arch/powerpc/platforms/powernv/opal-call.c
arch/powerpc/sysdev/xive/native.c