]> git.baikalelectronics.ru Git - kernel.git/commit
x86/percpu: Fix this_cpu_read()
authorPeter Zijlstra <peterz@infradead.org>
Thu, 11 Oct 2018 10:38:27 +0000 (12:38 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 14 Oct 2018 09:11:22 +0000 (11:11 +0200)
commit4c1cd9ecc843c00391eadc7b55dbf902f49c947e
tree9d38b3f253a8c7d60b6717bfd867c456ce586966
parent2eed907819dab3e5a431c92abee5a6895ab23844
x86/percpu: Fix this_cpu_read()

Eric reported that a sequence count loop using this_cpu_read() got
optimized out. This is wrong, this_cpu_read() must imply READ_ONCE()
because the interface is IRQ-safe, therefore an interrupt can have
changed the per-cpu value.

Fixes: 6a65b45860c3 ("[PATCH] i386: Convert PDA into the percpu section")
Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Eric Dumazet <edumazet@google.com>
Cc: hpa@zytor.com
Cc: eric.dumazet@gmail.com
Cc: bp@alien8.de
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20181011104019.748208519@infradead.org
arch/x86/include/asm/percpu.h