]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()"
authorJia He <justin.he@arm.com>
Tue, 20 Jul 2021 13:26:55 +0000 (21:26 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Jul 2021 14:26:06 +0000 (07:26 -0700)
commit4bef4027610e51fa8c2553a0b2ab841ec23c3d59
tree4f7c482a9ce3a297758a0eec568cbfbad507cbb8
parent9b095a6a32ead808193bc93d63de3a73f29e79da
Revert "qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()"

This reverts commit 1cf4048bcd2b59790f5c63d64c9428548371c68f.

That patch added additional spin_{un}lock_bh(), which was harmless
but pointless. The orginal code path has guaranteed the pair of
spin_{un}lock_bh().

We'd better revert it before we find the exact root cause of the
bug_on mentioned in that patch.

Fixes: 1cf4048bcd2b ("qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()")
Cc: David S. Miller <davem@davemloft.net>
Cc: Prabhakar Kushwaha <pkushwaha@marvell.com>
Signed-off-by: Jia He <justin.he@arm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_mcp.c