]> git.baikalelectronics.ru Git - kernel.git/commit
Merge branch 'selftests-fib_tests-simplifications-verbosity-and-a-race'
authorDavid S. Miller <davem@davemloft.net>
Tue, 13 Feb 2018 19:34:29 +0000 (14:34 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Feb 2018 19:34:29 +0000 (14:34 -0500)
commit4b982986266e95a7b0fd6adca354a17a3f1745ee
tree621fd561ed3ec2ffe9c94dc33f7abee560662e91
parentf6432d57e5801911c00d690b188f9097fd6e1315
parent41b164b2a35acbc87d2a3e40597cc2098364a5ad
Merge branch 'selftests-fib_tests-simplifications-verbosity-and-a-race'

David Ahern says:

====================
selftests: fib_tests: simplifications, verbosity and a race

Improve efficiency of fib_tests.sh and make the test result more verbose,
from this summary:
$ fib_tests.sh is failing in a VM:
    $ fib_tests.sh
    Running netdev unregister tests
    PASS: unicast route test
    PASS: multipath route test
    Running netdev down tests
    PASS: unicast route test
    PASS: multipath route test
    Running netdev carrier change tests
    PASS: local route carrier test
    FAIL: unicast route carrier test

where a single entry actually corresponds to many checks to a much more
verbse output that clarifies test cases:
$fib_tests.sh
Single path route carrier test
    ....
    Carrier down
        IPv4 fibmatch                                         [ OK ]
        IPv6 fibmatch                                         [ OK ]
        IPv4 linkdown flag set                                [FAIL]
        IPv6 linkdown flag set                                [FAIL]
    Second address added with carrier down
        IPv4 fibmatch                                         [ OK ]
        IPv6 fibmatch                                         [ OK ]
        IPv4 linkdown flag set                                [FAIL]
        IPv6 linkdown flag set                                [ OK ]

And then fix the race in changing carrier down on dummy device to checking
the corresponding routes.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>