]> git.baikalelectronics.ru Git - kernel.git/commit
net: apple: mace: don't call dev_kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 8 Dec 2022 13:37:34 +0000 (21:37 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:27 +0000 (13:32 +0100)
commit4b4329415dbcb7c0a746233a552e1805209db912
tree8c65f0491456fd6c5cdd00177572018e7017f87f
parent7a48fc52adb30788daeddaaaf56ab9efaa8be8d2
net: apple: mace: don't call dev_kfree_skb() under spin_lock_irqsave()

[ Upstream commit 51f0c50961710240a5720937c0ab2897f6af294a ]

It is not allowed to call kfree_skb() or consume_skb() from hardware
interrupt context or with hardware interrupts being disabled.

It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead.
The difference between them is free reason, dev_kfree_skb_irq() means
the SKB is dropped in error and dev_consume_skb_irq() means the SKB
is consumed in normal.

In this case, dev_kfree_skb() is called in mace_tx_timeout() to drop
the SKB, when tx timeout, so replace it with dev_kfree_skb_irq().

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/apple/mace.c