]> git.baikalelectronics.ru Git - kernel.git/commit
parisc: led: Fix potential null-ptr-deref in start_task()
authorShang XiaoJing <shangxiaojing@huawei.com>
Thu, 17 Nov 2022 02:45:14 +0000 (10:45 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Jan 2023 10:11:55 +0000 (11:11 +0100)
commit4a6773738dff1693a673a535426af5c42044ceac
tree17aa381cf8c59951aff144c75feb7c50be1fa86c
parent66a8f613361d4b76e384ce5a7c196f86cdf5fdb7
parisc: led: Fix potential null-ptr-deref in start_task()

commit 41f563ab3c33698bdfc3403c7c2e6c94e73681e4 upstream.

start_task() calls create_singlethread_workqueue() and not checked the
ret value, which may return NULL. And a null-ptr-deref may happen:

start_task()
    create_singlethread_workqueue() # failed, led_wq is NULL
    queue_delayed_work()
        queue_delayed_work_on()
            __queue_delayed_work()  # warning here, but continue
                __queue_work()      # access wq->flags, null-ptr-deref

Check the ret value and return -ENOMEM if it is NULL.

Fixes: cb29b9be72bd ("[PARISC] Use work queue in LED/LCD driver instead of tasklet.")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/parisc/led.c