]> git.baikalelectronics.ru Git - kernel.git/commit
bpf, sk_msg: Don't clear saved sock proto on restore
authorJakub Sitnicki <jakub@cloudflare.com>
Mon, 17 Feb 2020 12:15:29 +0000 (12:15 +0000)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 19 Feb 2020 15:54:05 +0000 (16:54 +0100)
commit4a3e11cb2ee4c5a2503e6167468c4c2776e04485
tree46c6266eb99a830456eea8a480e16f11d9d5a871
parent530e049d5805e22e9f6cd89386a8f40999982c07
bpf, sk_msg: Don't clear saved sock proto on restore

There is no need to clear psock->sk_proto when restoring socket protocol
callbacks in sk->sk_prot. The psock is about to get detached from the sock
and eventually destroyed. At worst we will restore the protocol callbacks
and the write callback twice.

This makes reasoning about psock state easier. Once psock is initialized,
we can count on psock->sk_proto always being set.

Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20200217121530.754315-3-jakub@cloudflare.com
include/linux/skmsg.h