]> git.baikalelectronics.ru Git - kernel.git/commit
IB/mthca: Check validity of output parameter pointer
authorLeon Romanovsky <leon@kernel.org>
Sat, 15 Apr 2017 15:47:25 +0000 (18:47 +0300)
committerDoug Ledford <dledford@redhat.com>
Fri, 21 Apr 2017 16:29:31 +0000 (12:29 -0400)
commit49e6f98a3ff22cb8743f4a6bd4b4b00e74516cf8
tree67ffd3e756db8f0519464b85952f3d3cc69a902c
parenta663a2ab6e24b6a20243ffaa85d24fd2088be6f9
IB/mthca: Check validity of output parameter pointer

The mthca driver didn't check supplied pointer to functions
mthca_cmd_poll() and mthca_cmd_wait(). This caused to the following
smatch errors:

drivers/infiniband/hw/mthca/mthca_cmd.c:371 mthca_cmd_poll() error: we previously assumed 'out_param' could be null (see line 353)
drivers/infiniband/hw/mthca/mthca_cmd.c:454 mthca_cmd_wait() error: we previously assumed 'out_param' could be null (see line 432)

In reality all callers of these functions are setting out_is_imm
flag are providing pointer too. However it is better to check
again to remove smatch errors to achieve warning free subsystem.

Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/mthca/mthca_cmd.c