]> git.baikalelectronics.ru Git - kernel.git/commit
zram: fix broken page writeback
authorMinchan Kim <minchan@kernel.org>
Sat, 13 Mar 2021 05:08:41 +0000 (21:08 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 13 Mar 2021 19:27:31 +0000 (11:27 -0800)
commit497d552fd36bd18b6412666b51a0ac8909b7d92c
treed3ee53d226db8a30707d94714c488e358a440785
parentbc8144c8c068b2d1d74d59d15acc8d4b11ba8ea9
zram: fix broken page writeback

commit 7af61caecee4 ("zram: support page writeback") introduced two
problems.  It overwrites writeback_store's return value as kstrtol's
return value, which makes return value zero so user could see zero as
return value of write syscall even though it wrote data successfully.

It also breaks index value in the loop in that it doesn't increase the
index any longer.  It means it can write only first starting block index
so user couldn't write all idle pages in the zram so lose memory saving
chance.

This patch fixes those issues.

Link: https://lkml.kernel.org/r/20210312173949.2197662-2-minchan@kernel.org
Fixes: 7af61caecee4("zram: support page writeback")
Signed-off-by: Minchan Kim <minchan@kernel.org>
Reported-by: Amos Bianchi <amosbianchi@google.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: John Dias <joaodias@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/block/zram/zram_drv.c