]> git.baikalelectronics.ru Git - kernel.git/commit
usb: gadget: r8a66597: fix a loop in set_feature()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 6 Sep 2021 09:42:21 +0000 (12:42 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Sep 2021 08:09:20 +0000 (10:09 +0200)
commit496569def1b5cecf44317e7cfb710b5613e95f11
tree26c5d8ba0028e57dfee05300d53b6be1c72a2d19
parentbc998271c3d918178387724dc96f51f9a5a7a9fa
usb: gadget: r8a66597: fix a loop in set_feature()

commit 17956b53ebff6a490baf580a836cbd3eae94892b upstream.

This loop is supposed to loop until if reads something other than
CS_IDST or until it times out after 30,000 attempts.  But because of
the || vs && bug, it will never time out and instead it will loop a
minimum of 30,000 times.

This bug is quite old but the code is only used in USB_DEVICE_TEST_MODE
so it probably doesn't affect regular usage.

Fixes: 8831c686ff1f ("usb: gadget: r8a66597-udc: add support for TEST_MODE")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210906094221.GA10957@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/r8a66597-udc.c