]> git.baikalelectronics.ru Git - kernel.git/commit
arm64: stacktrace: Make stack walk callback consistent with generic code
authorMark Brown <broonie@kernel.org>
Mon, 14 Sep 2020 15:34:08 +0000 (16:34 +0100)
committerWill Deacon <will@kernel.org>
Fri, 18 Sep 2020 13:24:16 +0000 (14:24 +0100)
commit49038bf0a5c1784bab4387950c78dc10e229ea31
tree9b02fe88c865f7f092af416073e25482b1c7467d
parentcf8b41e79b78d3aa7f6bc888f9f445282f14dab5
arm64: stacktrace: Make stack walk callback consistent with generic code

As with the generic arch_stack_walk() code the arm64 stack walk code takes
a callback that is called per stack frame. Currently the arm64 code always
passes a struct stackframe to the callback and the generic code just passes
the pc, however none of the users ever reference anything in the struct
other than the pc value. The arm64 code also uses a return type of int
while the generic code uses a return type of bool though in both cases the
return value is a boolean value and the sense is inverted between the two.

In order to reduce code duplication when arm64 is converted to use
arch_stack_walk() change the signature and return sense of the arm64
specific callback to match that of the generic code.

Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Link: https://lore.kernel.org/r/20200914153409.25097-3-broonie@kernel.org
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/include/asm/stacktrace.h
arch/arm64/kernel/perf_callchain.c
arch/arm64/kernel/return_address.c
arch/arm64/kernel/stacktrace.c