]> git.baikalelectronics.ru Git - kernel.git/commit
cgroup: Iterate tasks that did not finish do_exit()
authorMichal Koutný <mkoutny@suse.com>
Fri, 24 Jan 2020 11:40:15 +0000 (12:40 +0100)
committerTejun Heo <tj@kernel.org>
Wed, 12 Feb 2020 22:02:53 +0000 (17:02 -0500)
commit48ab2296b456e66099f18b3c21faec453ce8f976
treeb18bb13e7ddc8ed4522b6bc095ad279ba341ebb1
parentba3a42dbbdc6fded830863e8a0657e17091d1a85
cgroup: Iterate tasks that did not finish do_exit()

PF_EXITING is set earlier than actual removal from css_set when a task
is exitting. This can confuse cgroup.procs readers who see no PF_EXITING
tasks, however, rmdir is checking against css_set membership so it can
transitionally fail with EBUSY.

Fix this by listing tasks that weren't unlinked from css_set active
lists.
It may happen that other users of the task iterator (without
CSS_TASK_ITER_PROCS) spot a PF_EXITING task before cgroup_exit(). This
is equal to the state before commit 0940dd91a4dc ("cgroup: Include dying
leaders with live threads in PROCS iterations") but it may be reviewed
later.

Reported-by: Suren Baghdasaryan <surenb@google.com>
Fixes: 0940dd91a4dc ("cgroup: Include dying leaders with live threads in PROCS iterations")
Signed-off-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
include/linux/cgroup.h
kernel/cgroup/cgroup.c