]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: aloop: Remove redundant locking in timer open function
authorAndrew Gabbasov <andrew_gabbasov@mentor.com>
Fri, 22 Nov 2019 17:52:17 +0000 (11:52 -0600)
committerTakashi Iwai <tiwai@suse.de>
Fri, 22 Nov 2019 18:11:23 +0000 (19:11 +0100)
commit482b273a9fda52f63ced95bd50aeaa63259468ae
treedd28c629626c8b0347a50113077bc53f9f8781af
parent32afef1af89e8dece2fc7307f9b3c5ecbc054b69
ALSA: aloop: Remove redundant locking in timer open function

loopback_parse_timer_id() uses snd_card_ref(), that can lock on mutex,
also snd_timer_instance_new() uses non-atomic allocation, that can sleep.
So, both functions can not be called from loopback_snd_timer_open()
with cable->lock spinlock locked.

Moreover, most part of loopback_snd_timer_open() function body works
when the opposite stream of the same cable does not yet exist, and
the current stream is not yet completely open and can't be running,
so existing locking of loopback->cable_lock mutex is enough to protect
from conflicts with simultaneous opening or closing.
Locking of cable->lock spinlock is not needed in this case.

Fixes: 7303e1b6578d ("ALSA: aloop: Support selection of snd_timer instead of jiffies")
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Link: https://lore.kernel.org/r/20191122175218.17187-1-andrew_gabbasov@mentor.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/drivers/aloop.c