]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vc4: txp: Force alpha to be 0xff if it's disabled
authorMaxime Ripard <maxime@cerno.tech>
Mon, 28 Mar 2022 15:36:56 +0000 (17:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:22:45 +0000 (10:22 +0200)
commit4829c085cffe7277bbe6f90efe51d8cc86d8641b
tree41c3f7de711cbec54bc00bdd6b6fbf0f0f46d704
parent803b965c8ef7a7c3e2bcab91c3ffaa73a09692f7
drm/vc4: txp: Force alpha to be 0xff if it's disabled

[ Upstream commit 84657b3deb2e05b025afe2fe6ef4cf8fd6e2c2f3 ]

If we use a format that has padding instead of the alpha component (such
as XRGB8888), it appears that the Transposer will fill the padding to 0,
disregarding what was stored in the input buffer padding.

This leads to issues with IGT, since it will set the padding to 0xff,
but will then compare the CRC of the two frames which will thus fail.
Another nice side effect is that it is now possible to just use the
buffer as ARGB.

Fixes: 2040cc595849 ("drm/vc4: Add support for the transposer block")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220328153659.2382206-4-maxime@cerno.tech
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/vc4/vc4_txp.c