]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: via82xx: Fix the missing snd_card_free() call at probe error
authorTakashi Iwai <tiwai@suse.de>
Tue, 12 Apr 2022 10:26:22 +0000 (12:26 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 12 Apr 2022 15:58:34 +0000 (17:58 +0200)
commit47a534b059db73e5605488d93cb6b2c2fce4c78e
tree643a41a462b3bcea8d40f4946af13eae94a1ca2d
parent7f86d17f017c7a3199abd9e1d258c26172a027c0
ALSA: via82xx: Fix the missing snd_card_free() call at probe error

The previous cleanup with devres may lead to the incorrect release
orders at the probe error handling due to the devres's nature.  Until
we register the card, snd_card_free() has to be called at first for
releasing the stuff properly when the driver tries to manage and
release the stuff via card->private_free().

This patch fixes it by calling snd_card_free() on the error from the
probe callback using a new helper function.

Fixes: ea77b4a792f2 ("ALSA: via82xx: Allocate resources with device-managed APIs")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220412102636.16000-26-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/via82xx.c
sound/pci/via82xx_modem.c