]> git.baikalelectronics.ru Git - kernel.git/commit
gfs2: Always check inode size of inline inodes
authorAndreas Gruenbacher <agruenba@redhat.com>
Sun, 4 Dec 2022 16:00:04 +0000 (17:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Apr 2023 09:16:46 +0000 (11:16 +0200)
commit47a0d36a66c02e113e465fa87acd39ef9a6b916a
tree2838befcc77ca71f9a7abdb2a10506f28529239b
parent0447ede72d42ec2b38b1cc52bc32fcbbf93ffa27
gfs2: Always check inode size of inline inodes

commit 5a64b01afc25a8add3336e5945a1edf36eca7147 upstream.

Check if the inode size of stuffed (inline) inodes is within the allowed
range when reading inodes from disk (gfs2_dinode_in()).  This prevents
us from on-disk corruption.

The two checks in stuffed_readpage() and gfs2_unstuffer_page() that just
truncate inline data to the maximum allowed size don't actually make
sense, and they can be removed now as well.

Reported-by: syzbot+7bb81dfa9cda07d9cd9d@syzkaller.appspotmail.com
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
[pchelkin@ispras.ru: adjust the inode variable inside gfs2_dinode_in with
the format used before upstream commit 2fc442816529 ("gfs2: Cosmetic
gfs2_dinode_{in,out} cleanup")]
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/gfs2/aops.c
fs/gfs2/bmap.c
fs/gfs2/glops.c