]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "x86, NUMA: Fix fakenuma boot failure"
authorDavid Rientjes <rientjes@google.com>
Thu, 21 Apr 2011 02:19:10 +0000 (19:19 -0700)
committerIngo Molnar <mingo@elte.hu>
Thu, 21 Apr 2011 09:30:59 +0000 (11:30 +0200)
commit477bea4536ea429fa7ab8f05c24421c48c24d6e4
tree16a21fe2caa4ed94c52643a1f4807647c37e5a31
parent8d43b82d1f918aa602acbcf19399de1f8d60f868
Revert "x86, NUMA: Fix fakenuma boot failure"

Andreas Herrmann reported that d394fa0c1cae ("x86, NUMA: Fix fakenuma
boot failure") causes certain physical NUMA topologies (for example
AMD Magny-Cours) to move sibling cpus to a single node when in reality
they are in separate domains.

This may result in some nodes being completely void of cpus, which
doesn't accurately represent the correct topology. The system will
boot, but will have suboptimal NUMA performance.

This commit was intended as a fix for NUMA emulation, but should
not cause a regression for real NUMA machines as a side effect.

( There will be a separate fix for the numa-debug code, which
  will not affect physical topologies. )

Reported-by: Andreas Herrmann <herrmann.der.user@googlemail.com>
Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/alpine.DEB.2.00.1104201918110.12634@chino.kir.corp.google.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/smpboot.c