]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: lpfc: Correct null ndlp reference on routine exit
authorJames Smart <james.smart@broadcom.com>
Mon, 30 Nov 2020 18:12:26 +0000 (10:12 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 1 Dec 2020 05:19:14 +0000 (00:19 -0500)
commit475228659cea6cc3da27e86e34f839abaddc52b7
tree2f317f729ba4a871a7d17bdd7b1cc77c54a2c9dd
parent7de1081eab1fc1b6bccc9c8d4ade1a884bd358b4
scsi: lpfc: Correct null ndlp reference on routine exit

smatch correctly called out a logic error with accessing a pointer after
checking it for null:

 drivers/scsi/lpfc/lpfc_els.c:2043 lpfc_cmpl_els_plogi()
 error: we previously assumed 'ndlp' could be null (see line 1942)

Adjust the exit point to avoid the trace printf ndlp reference. A trace
entry was already generated when the ndlp was checked for null.

Link: https://lore.kernel.org/r/20201130181226.16675-1-james.smart@broadcom.com
Fixes: 324dc1dfd166 ("scsi: lpfc: Rework locations of ndlp reference taking")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_els.c