]> git.baikalelectronics.ru Git - kernel.git/commit
firewire: net: fix maximum possible MTU
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Sun, 23 Oct 2016 14:29:03 +0000 (16:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Oct 2016 21:28:50 +0000 (17:28 -0400)
commit46a1dff4e818dedec92570a5cf2dc87f3434b8c1
treed07a89e6ba1d5086fbdc60ab4476fcf5186c58b1
parentf60b5972ef0d501ebb11b85ae2008d5bc423d8fa
firewire: net: fix maximum possible MTU

Commit 498fedb286bf ("net: use core MTU range checking in misc drivers")
mistakenly introduced an upper limit for firewire-net's MTU based on the
local link layer controller's reception capability.  Revert this.  Neither
RFC 2734 nor our implementation impose any particular upper limit.

Actually, to be on the safe side and to make the code explicit, set
ETH_MAX_MTU = 65535 as upper limit now.

(I replaced sizeof(struct rfc2734_header) by the equivalent
RFC2374_FRAG_HDR_SIZE in order to avoid distracting long/int conversions.)

Fixes: 498fedb286bf('net: use core MTU range checking in misc drivers')
CC: netdev@vger.kernel.org
CC: linux1394-devel@lists.sourceforge.net
CC: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Acked-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/firewire/net.c