]> git.baikalelectronics.ru Git - kernel.git/commit
iio: adc: stm32: fix a current leak by resetting pcsel before disabling vdda
authorFabrice Gasnier <fabrice.gasnier@foss.st.com>
Fri, 22 Oct 2021 12:19:29 +0000 (14:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Dec 2021 09:57:21 +0000 (10:57 +0100)
commit46987c82aaecf120828ee6bb992f6b67463dbcdb
treedc17f7fb4bac150d552dc64427d4e96a04d79616
parentd273efa9a5ae0a922762bdeaa96d75cbd9e358e4
iio: adc: stm32: fix a current leak by resetting pcsel before disabling vdda

commit 3516d864b0d9aeafa7549f9345d423b3412e3a6c upstream.

Some I/Os are connected to ADC input channels, when the corresponding bit
in PCSEL register are set on STM32H7 and STM32MP15. This is done in the
prepare routine of stm32-adc driver.
There are constraints here, as PCSEL shouldn't be set when VDDA supply
is disabled. Enabling/disabling of VDDA supply in done via stm32-adc-core
runtime PM routines (before/after ADC is enabled/disabled).

Currently, PCSEL remains set when disabling ADC. Later on, PM runtime
can disable the VDDA supply. This creates some conditions on I/Os that
can start to leak current.
So PCSEL needs to be cleared when disabling the ADC.

Fixes: 85c0c4482017 ("iio: adc: stm32: add support for STM32H7")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Reviewed-by: Olivier Moysan <olivier.moysan@foss.st.com>
Link: https://lore.kernel.org/r/1634905169-23762-1-git-send-email-fabrice.gasnier@foss.st.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/adc/stm32-adc.c