]> git.baikalelectronics.ru Git - kernel.git/commit
[media] cx18: Replace memcpy with struct assignment
authorEzequiel Garcia <elezegarcia@gmail.com>
Tue, 23 Oct 2012 18:57:21 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 21:02:24 +0000 (19:02 -0200)
commit46825d2a9883e3ab43ddcacb34d4627a297bb8bb
tree1b43d47b3373a1bd05e8294c2f76a289e9540309
parent1b2160506ef9e5e177e36d64b4e5c25b0de633c3
[media] cx18: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/pci/cx18/cx18-i2c.c