]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: zfcp: Remove unneeded INIT_LIST_HEAD() for FSF requests
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 14 Apr 2021 17:07:59 +0000 (19:07 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 16 Apr 2021 02:19:39 +0000 (22:19 -0400)
commit45a7a2ea3c0bcef90506348afe1b517ffec1fa6f
tree24aeb7656ef655a55657a2a667a541a8fa1fdc44
parentc7f6686f526b5d6399b310370bd87b03cac44a9c
scsi: zfcp: Remove unneeded INIT_LIST_HEAD() for FSF requests

INIT_LIST_HEAD() is only needed for actual list heads, while req->list is
used as a list entry.

Note that when the error path in zfcp_fsf_req_send() removes the request
from the adapter's list of pending requests, it actually looks up the
request from the zfcp_reqlist - rather than just calling list_del().  So
there's no risk of us calling list_del() on a request that hasn't been
added to any list yet.

Link: https://lore.kernel.org/r/254dc0ae28dccc43ab0b1079ef2c8dcb5fe1d2e4.1618417667.git.bblock@linux.ibm.com
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/s390/scsi/zfcp_fsf.c