]> git.baikalelectronics.ru Git - kernel.git/commit
s390: fix detection of vector enhancements facility 1 vs. vector packed decimal facility
authorDavid Hildenbrand <david@redhat.com>
Mon, 3 May 2021 12:12:44 +0000 (14:12 +0200)
committerHeiko Carstens <hca@linux.ibm.com>
Tue, 4 May 2021 17:10:56 +0000 (19:10 +0200)
commit455fc2c266faf2570b228d261c154e1a54fe3c0e
treeb18fb71bab9c3e8db7ac871f9300c610565f453d
parent0ec1a8a49fd1d2120f8e3e92897d106a59f45690
s390: fix detection of vector enhancements facility 1 vs. vector packed decimal facility

The PoP documents:
134: The vector packed decimal facility is installed in the
     z/Architecture architectural mode. When bit 134 is
     one, bit 129 is also one.
135: The vector enhancements facility 1 is installed in
     the z/Architecture architectural mode. When bit 135
     is one, bit 129 is also one.

Looks like we confuse the vector enhancements facility 1 ("EXT") with the
Vector packed decimal facility ("BCD"). Let's fix the facility checks.

Detected while working on QEMU/tcg z14 support and only unlocking
the vector enhancements facility 1, but not the vector packed decimal
facility.

Fixes: 18a41a29020a ("s390: report new vector facilities")
Cc: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Link: https://lore.kernel.org/r/20210503121244.25232-1-david@redhat.com
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
arch/s390/kernel/setup.c