]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: core: don't disable device interrupts in phy_change
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 30 Nov 2017 22:57:00 +0000 (23:57 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Dec 2017 15:23:42 +0000 (10:23 -0500)
commit451b5fbae6c0a330124a4ef5426f5f6f3e0546ff
tree6b257a9110766e92b0aaff09b0f973970c40fa8a
parent0e03dfa80bc3918b074da621e04b28cc8660cf76
net: phy: core: don't disable device interrupts in phy_change

If state is not PHY_HALTED I see no need to temporarily disable
interrupts on the device. As long as the current interrupt isn't acked
on the device no new interrupt can happen anyway.

In addition remove a unneeded enabling of interrupts in the state
machine when handling state PHY_CHANGELINK.

Tested on a Odroid-C2 with RTL8211F phy in interrupt mode.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c