]> git.baikalelectronics.ru Git - kernel.git/commit
cgroup: fix cgroup_subsys_state leak for seq_files
authorTejun Heo <tj@kernel.org>
Wed, 27 Nov 2013 23:16:21 +0000 (18:16 -0500)
committerTejun Heo <tj@kernel.org>
Wed, 27 Nov 2013 23:16:21 +0000 (18:16 -0500)
commit44d64a62fd1a5a1287b0bb286da601eb33da3f03
tree3505166d31674b264cc00f7a5fa6836f6f7b35cf
parentff545519169a13d04c56e3fc101c934425169a8a
cgroup: fix cgroup_subsys_state leak for seq_files

If a cgroup file implements either read_map() or read_seq_string(),
such file is served using seq_file by overriding file->f_op to
cgroup_seqfile_operations, which also overrides the release method to
single_release() from cgroup_file_release().

Because cgroup_file_open() didn't use to acquire any resources, this
used to be fine, but since 1e0072f25b78 ("cgroup: pin
cgroup_subsys_state when opening a cgroupfs file"), cgroup_file_open()
pins the css (cgroup_subsys_state) which is put by
cgroup_file_release().  The patch forgot to update the release path
for seq_files and each open/release cycle leaks a css reference.

Fix it by updating cgroup_file_release() to also handle seq_files and
using it for seq_file release path too.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org # v3.12
kernel/cgroup.c