]> git.baikalelectronics.ru Git - kernel.git/commit
tpm, tpm_tis: Decorate tpm_tis_gen_interrupt() with request_locality()
authorLukasz Majczak <lma@semihalf.com>
Tue, 16 Feb 2021 08:17:49 +0000 (10:17 +0200)
committerJarkko Sakkinen <jarkko@kernel.org>
Wed, 24 Feb 2021 16:53:22 +0000 (18:53 +0200)
commit44bbf07b5732b6b8854780d1dfcf371617bfd88e
tree8d818f64c0a4ddb2848748c7d6605be180331e06
parent832083c54498d903384a181a0fd3a3cf25007df3
tpm, tpm_tis: Decorate tpm_tis_gen_interrupt() with request_locality()

This is shown with Samsung Chromebook Pro (Caroline) with TPM 1.2
(SLB 9670):

[    4.324298] TPM returned invalid status
[    4.324806] WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:275 tpm_tis_status+0x86/0x8f

Background
==========

TCG PC Client Platform TPM Profile (PTP) Specification, paragraph 6.1 FIFO
Interface Locality Usage per Register, Table 39 Register Behavior Based on
Locality Setting for FIFO - a read attempt to TPM_STS_x Registers returns
0xFF in case of lack of locality.

The fix
=======

Decorate tpm_tis_gen_interrupt() with request_locality() and
release_locality().

Cc: Laurent Bigonville <bigon@debian.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: stable@vger.kernel.org
Fixes: 5c5b996c8cb9 ("tpm: take TPM chip power gating out of tpm_transmit()")
Signed-off-by: Lukasz Majczak <lma@semihalf.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm_tis_core.c