]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ea8b5d9) | patch
USB: legousbtower: fix a signedness bug in tower_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 11 Oct 2019 14:11:15 +0000 (17:11 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Oct 2019 18:07:43 +0000 (20:07 +0200)
commit44aeca192c2d9b730ee4f37f85f23b30d8b26e9f
tree3098b5352d2a22355d77def24e5c11c88b193f83tree | snapshot
parentea8b5d9a6cd7850b0757d8d05d146fb536ef86eecommit | diff
USB: legousbtower: fix a signedness bug in tower_probe()

The problem is that sizeof() is unsigned long so negative error codes
are type promoted to high positive values and the condition becomes
false.

Fixes: 5bcf17f09d34 ("USB: legousbtower: fix slab info leak at probe")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191011141115.GA4521@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/legousbtower.c diff | blob | history
Linux Kernel Source Tree.