]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: arcmsr: remove redundant check for secs < 0
authorColin Ian King <colin.king@canonical.com>
Sat, 9 Dec 2017 00:34:14 +0000 (00:34 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 12 Dec 2017 02:37:08 +0000 (21:37 -0500)
commit4467c83711766fcdb47aa26e4a91a1ee1860f5fc
tree24ed2f0f85c2b1f0a5fdb90a07ed15b39c6148b6
parent7bc0434c3bbe138c05e048f2420f47b3c7988780
scsi: arcmsr: remove redundant check for secs < 0

The check for secs being less than zero is redundant for two reasons.
Firstly, secs is unsigned so the check is always going to be false.
Secondly, if secs was signed the proceeding calculation of secs is never
going to be negative.  Hence we can remove this redundant check and day
and secs re-adjustment.

Detected by static analysis with smatch:
arcmsr_set_iop_datetime() warn: unsigned 'secs' is never less than zero.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ching Huang <ching2048@areca.com.tw>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/arcmsr/arcmsr_hba.c