]> git.baikalelectronics.ru Git - kernel.git/commit
libata-scsi: better style in ata_msense_*()
authorTom Yan <tom.ty89@gmail.com>
Tue, 19 Jul 2016 20:39:28 +0000 (04:39 +0800)
committerTejun Heo <tj@kernel.org>
Wed, 20 Jul 2016 15:19:35 +0000 (11:19 -0400)
commit4463eac69171de7e5a96b9e0364515e194e553e5
treef0a825ac86cea5e080250a6689fa43497855a3a5
parentbc8c1d62aa5c867b215155d8debf5c044ba17293
libata-scsi: better style in ata_msense_*()

`changeable` is the "version" of mode page requested by the user.
It will be less confusing/misleading if we do not check it
"together" with the setting bits of the drive.

Not to mention that we currently have ata_mselect_*() implemented
in a way that each of them will serve exclusively a particular bit
on each page. The old style will hence make the condition look even
more unnecessarily arcane if the ata_msense_*() is reflecting more
than one bit.

Signed-off-by: Tom Yan <tom.ty89@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libata-scsi.c