]> git.baikalelectronics.ru Git - kernel.git/commit
lan78xx: Don't reset the interface on open
authorPhil Elwell <phil@raspberrypi.org>
Tue, 10 Apr 2018 12:18:25 +0000 (13:18 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Apr 2018 18:44:45 +0000 (14:44 -0400)
commit44561ee04bbac1ae60c0bbd2687cd26e54f8b6aa
treee31eeb252287269fc1f33d030497ddcbd3305f72
parent994e3c10a432a813564d6feca28b23d5cf05bacf
lan78xx: Don't reset the interface on open

Commit c1910b518be1 ("lan78xx: Connect phy early") moves the PHY
initialisation into lan78xx_probe, but lan78xx_open subsequently calls
lan78xx_reset. As well as forcing a second round of link negotiation,
this reset frequently prevents the phy interrupt from being generated
(even though the link is up), rendering the interface unusable.

Fix this issue by removing the lan78xx_reset call from lan78xx_open.

Fixes: c1910b518be1 ("lan78xx: Connect phy early")
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/lan78xx.c