]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE
authorJani Nikula <jani.nikula@intel.com>
Fri, 21 Jan 2022 13:29:57 +0000 (15:29 +0200)
committerJani Nikula <jani.nikula@intel.com>
Mon, 24 Jan 2022 12:02:16 +0000 (14:02 +0200)
commit444751bb02149ae21560ad85106fea9b6a16b653
tree12330ec76022d4591e2bade44786dcad4e272176
parenta2ab89158f8f3f8280ce19e5a36b5e079c5901df
drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE

In general, we should avoid redefining kernel macros like this. It can
get confusing, and what gets used will depend on whether the header is
included or not. Moreover, we should prefer drm_WARN_ON() and
drm_WARN_ON_ONCE() anyway, which include the stringified error condition
in the message.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220121132957.3778555-1-jani.nikula@intel.com
drivers/gpu/drm/i915/i915_utils.h