]> git.baikalelectronics.ru Git - kernel.git/commit
net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts
authorVincent Chen <vincentc@andestech.com>
Wed, 21 Nov 2018 01:38:11 +0000 (09:38 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Nov 2018 00:57:39 +0000 (16:57 -0800)
commit443bd0bd0247b891835265bad9995b962be40adc
tree9da1b8b14386d93e424e6e361567697d2f4bf392
parent3df43151076558c1f6fde562a70a17d0d48bc4a0
net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts

In the original ftmac100_interrupt(), the interrupts are only disabled when
the condition "netif_running(netdev)" is true. However, this condition
causes kerenl hang in the following case. When the user requests to
disable the network device, kernel will clear the bit __LINK_STATE_START
from the dev->state and then call the driver's ndo_stop function. Network
device interrupts are not blocked during this process. If an interrupt
occurs between clearing __LINK_STATE_START and stopping network device,
kernel cannot disable the interrupts due to the condition
"netif_running(netdev)" in the ISR. Hence, kernel will hang due to the
continuous interruption of the network device.

In order to solve the above problem, the interrupts of the network device
should always be disabled in the ISR without being restricted by the
condition "netif_running(netdev)".

[V2]
Remove unnecessary curly braces.

Signed-off-by: Vincent Chen <vincentc@andestech.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/faraday/ftmac100.c