]> git.baikalelectronics.ru Git - kernel.git/commit
erofs: Revert "erofs: fix kvcalloc() misuse with __GFP_NOFAIL"
authorGao Xiang <hsiangkao@linux.alibaba.com>
Thu, 9 Mar 2023 05:31:47 +0000 (13:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Mar 2023 07:50:28 +0000 (08:50 +0100)
commit4411d49a98341e9aaead3f0ccc5b26f1cce5cb33
tree8ebc232ca7ef9919b76e3fc34ee4e97fc3292783
parent80d759f522561aadc281ada98d7baf8eb8cccb95
erofs: Revert "erofs: fix kvcalloc() misuse with __GFP_NOFAIL"

[ Upstream commit 3c4aa85813458506318e6b19318562fa3c2500e0 ]

Let's revert commit 5cccc5fbb265 ("erofs: fix kvcalloc() misuse with
__GFP_NOFAIL") since kvmalloc() already supports __GFP_NOFAIL in commit
318e576ba783 ("mm: allow !GFP_KERNEL allocations for kvmalloc").  So
the original fix was wrong.

Actually there was some issue as [1] discussed, so before that mm fix
is landed, the warn could still happen but applying this commit first
will cause less.

[1] https://lore.kernel.org/r/20230305053035.1911-1-hsiangkao@linux.alibaba.com

Fixes: 5cccc5fbb265 ("erofs: fix kvcalloc() misuse with __GFP_NOFAIL")
Reviewed-by: Chao Yu <chao@kernel.org>
Link: https://lore.kernel.org/r/20230309053148.9223-1-hsiangkao@linux.alibaba.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/erofs/zdata.c