]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: Modify configuration method of EEE timers
authorVineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com>
Thu, 1 Oct 2020 15:56:09 +0000 (23:56 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 3 Oct 2020 23:40:25 +0000 (16:40 -0700)
commit43cd9c60591d7535ceeebea93b108ee975e8f21e
tree2673c6b244959629596cfba6bdd5161f3d1b9f03
parent8ab14b49a9812878b4c5afbdf63d24080e1cc180
net: stmmac: Modify configuration method of EEE timers

Ethtool manual stated that the tx-timer is the "the amount of time the
device should stay in idle mode prior to asserting its Tx LPI". The
previous implementation for "ethtool --set-eee tx-timer" sets the LPI TW
timer duration which is not correct. Hence, this patch fixes the
"ethtool --set-eee tx-timer" to configure the EEE LPI timer.

The LPI TW Timer will be using the defined default value instead of
"ethtool --set-eee tx-timer" which follows the EEE LS timer implementation.

Changelog V2
*Not removing/modifying the eee_timer.
*EEE LPI timer can be configured through ethtool and also the eee_timer
module param.
*EEE TW Timer will be configured with default value only, not able to be
configured through ethtool or module param. This follows the implementation
of the EEE LS Timer.

Fixes: 6d1634718fa8 ("stmmac: add the Energy Efficient Ethernet support")
Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com>
Signed-off-by: Voon Weifeng <weifeng.voon@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac.h
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c