]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: Intel: Atom: sst_loader: remove always-true condition
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 13 Aug 2020 20:01:35 +0000 (15:01 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 18 Aug 2020 10:50:15 +0000 (11:50 +0100)
commit43b67928d8ce21a5442f63aa3e412adf1929ca07
treea6a8ef66ab21e26351a07c121887c18fca2bdcc1
parent809f17c120e6bfcadb2cc08444a33c2fe0fb0996
ASoC: Intel: Atom: sst_loader: remove always-true condition

Fix cppcheck warning:

sound/soc/intel/atom/sst/sst_loader.c:401:43: style: Redundant
condition: If 'EXPR == 4', the comparison 'EXPR != 3' is always
true. [redundantCondition]

 if (sst_drv_ctx->sst_state !=  SST_RESET ||
                                          ^

In this case, if sst_state == SST_SHUTDOWN then the first test is
already true. 2014 bug, yay.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200813200147.61990-10-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/atom/sst/sst_loader.c