]> git.baikalelectronics.ru Git - kernel.git/commit
53c700: fix BUG on untagged commands
authorJames Bottomley <jejb@linux.vnet.ibm.com>
Tue, 14 Jun 2016 05:00:07 +0000 (22:00 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 15 Jun 2016 01:17:22 +0000 (21:17 -0400)
commit4388312e97e5c0747f1fbd0db31de8273f1b7fa8
tree987be35122c11d6a30b0c4076fa81a02d4fde356
parentcb5527a10252363d7e3b77af38762e6a83029d57
53c700: fix BUG on untagged commands

The untagged command case in the 53c700 driver has been broken since
host wide tags were enabled because the replaced scsi_find_tag()
function had a special case for the tag value SCSI_NO_TAG to retrieve
sdev->current_cmnd.  The replacement function scsi_host_find_tag() has
no such special case and returns NULL causing untagged commands to
trigger a BUG() in the driver.  Inspection shows that the 53c700 is the
only driver using this SCSI_NO_TAG case, so a local fix in the driver
suffices to fix this problem globally.

Fixes: 8ace2a886b0 - "scsi: use host wide tags by default"
Cc: stable@vger.kernel.org # 4.4+
Reported-by: Helge Deller <deller@gmx.de>
Tested-by: Helge Deller <deller@gmx.de>
Signed-off-by: James Bottomley <jejb@linux.vnet.ibm.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/53c700.c