]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: lpc18xx: fix GPIO controller driver build as a module
authorVladimir Zapolskiy <vz@mleia.com>
Sat, 8 Dec 2018 14:38:41 +0000 (16:38 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 10 Dec 2018 08:10:46 +0000 (09:10 +0100)
commit4327283d2bf3907e259a55a8d82d9b13f9d8c9e6
tree68236d933b38ccf3e12c2b9ddf8fd0ed3dda711d
parent3a3bd90993217eb6bb5437417e6992b3dee0bddf
gpio: lpc18xx: fix GPIO controller driver build as a module

The problem is reported for allmodconfig build setup:

  ERROR: "irq_chip_retrigger_hierarchy" [drivers/gpio/gpio-lpc18xx.ko] undefined!
  make[2]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
  make[1]: *** [Makefile:1271: modules] Error 2

My testing in runtime shows that it is sufficient to remove .irq_retrigger
callback, which is assigned to unexported irq_chip_retrigger_hierarchy()
function, I did't observe any regressions, and thus apparently it is a
better fix rather than exporting the function defined in kernel/irq/chip.c
(see commit a7b95477c076 ("genirq: Export IRQ functions for module use"))
or sticking the GPIO controller driver build to built-in option only.

Reported-by: kbuild test robot <lkp@intel.com>
Fixes: dba9508f7541 ("gpio: lpc18xx: add GPIO pin interrupt controller support")
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-lpc18xx.c