]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ALSA: hda - Allow power_save_controller option override DCAPS"
authorTakashi Iwai <tiwai@suse.de>
Thu, 4 Apr 2013 13:35:24 +0000 (15:35 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 4 Apr 2013 13:35:39 +0000 (15:35 +0200)
commit42dba631f9188831d677994a31ba4e76dd521a77
treeae99f026484bbd912abfed8fb5e565f5a3a7a900
parent90d7555476da18b199124a1137df4aa71c98b6e6
Revert "ALSA: hda - Allow power_save_controller option override DCAPS"

This reverts commit e4e91dd3bfaa74af209dee1a68e6e7a7591517ce.

The commit [e4e91dd3bf: ALSA: hda - Allow power_save_controller option
override DCAPS] changed the behavior of power_save_controller so that
it can override the driver capability.  This assumed that this option
is rarely changed dynamically unlike power_save option.  Too naive.

It turned out that the user-space power-management tool tries to set
power_save_controller option to 1 together with power_save option
without knowing what's actually doing.  This enabled forcibly the
runtime PM of the controller,  which is known to be broken om many
chips thus disabled as default.

So, the only sane fix is to revert this commit again.  It was intended
to ease debugging/testing for runtime PM enablement, but obviously we
need another way for it.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=56171
Reported-and-tested-by: Nikita Tsukanov <keks9n@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Documentation/sound/alsa/ALSA-Configuration.txt
sound/pci/hda/hda_intel.c