]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: tag_8021q: Future-proof the reserved fields in the custom VID
authorVladimir Oltean <olteanv@gmail.com>
Sun, 25 Aug 2019 18:32:12 +0000 (21:32 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Aug 2019 03:31:12 +0000 (20:31 -0700)
commit42b662ab3a96736f9bf21b8877fa5a8aa0a830f3
treece18c6dc616360102275569798204bf33144ab8b
parentaa3ef3da764f7012944a6ee3baa3f5ac677d0a47
net: dsa: tag_8021q: Future-proof the reserved fields in the custom VID

After witnessing the discussion in https://lkml.org/lkml/2019/8/14/151
w.r.t. ioctl extensibility, it became clear that such an issue might
prevent that the 3 RSV bits inside the DSA 802.1Q tag might also suffer
the same fate and be useless for further extension.

So clearly specify that the reserved bits should currently be
transmitted as zero and ignored on receive. The DSA tagger already does
this (and has always did), and is the only known user so far (no
Wireshark dissection plugin, etc). So there should be no incompatibility
to speak of.

Fixes: 5d32ebec4fc7 ("net: dsa: tag_8021q: Create a stable binary format")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/tag_8021q.c