]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: max77686: Properly handle regmap_irq_get_virq() error code
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Thu, 4 Feb 2016 00:26:35 +0000 (09:26 +0900)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Thu, 4 Feb 2016 22:44:14 +0000 (23:44 +0100)
commit42af27a29ba8ef89dbd2fe40c460324696cba1a3
tree3d559251aec9b2bc37e4c63095803cd7b542821c
parentec475c6c13153bfb9e968126f9deb84691a308ff
rtc: max77686: Properly handle regmap_irq_get_virq() error code

The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions
but driver checked only for value of 0.

This could lead to a cast of -EINVAL to an unsigned int used as a
interrupt number for devm_request_threaded_irq(). Although this is not
yet fatal (devm_request_threaded_irq() will just fail with -EINVAL) but
might be a misleading when diagnosing errors.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 45eccda0f0fe ("mfd: max77686: Convert to use regmap_irq")
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-max77686.c