]> git.baikalelectronics.ru Git - kernel.git/commit
nfs: Fix ugly referral attributes
authorChuck Lever <chuck.lever@oracle.com>
Sun, 5 Nov 2017 20:45:22 +0000 (15:45 -0500)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Fri, 17 Nov 2017 21:43:52 +0000 (16:43 -0500)
commit4248de15aa1f08950248e8080f64c8aac425e239
tree74afd3e29a68c0b319610d0c7a83dbe5b3a9a982
parent04a7e405d383c0dee9f07b57a7d403b898ccdc80
nfs: Fix ugly referral attributes

Before traversing a referral and performing a mount, the mounted-on
directory looks strange:

dr-xr-xr-x. 2 4294967294 4294967294 0 Dec 31  1969 dir.0

nfs4_get_referral is wiping out any cached attributes with what was
returned via GETATTR(fs_locations), but the bit mask for that
operation does not request any file attributes.

Retrieve owner and timestamp information so that the memcpy in
nfs4_get_referral fills in more attributes.

Changes since v1:
- Don't request attributes that the client unconditionally replaces
- Request only MOUNTED_ON_FILEID or FILEID attribute, not both
- encode_fs_locations() doesn't use the third bitmask word

Fixes: cd8f4792e6f6 ("NFSv4: Follow a referral")
Suggested-by: Pradeep Thomas <pradeepthomas@gmail.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/nfs4proc.c