]> git.baikalelectronics.ru Git - kernel.git/commit
net sched actions: fix GETing actions
authorJamal Hadi Salim <jhs@mojatatu.com>
Mon, 19 Sep 2016 23:02:51 +0000 (19:02 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Sep 2016 03:34:55 +0000 (23:34 -0400)
commit41d95929beaf691d86979b2293b51075724b22c9
treeab8e60904b6455817d06a5a3acbe06b6f0028a63
parent746be93f8ea357b7a54601d07f80f76166731a9b
net sched actions: fix GETing actions

With the batch changes that translated transient actions into
a temporary list lost in the translation was the fact that
tcf_action_destroy() will eventually delete the action from
the permanent location if the refcount is zero.

Example of what broke:
...add a gact action to drop
sudo $TC actions add action drop index 10
...now retrieve it, looks good
sudo $TC actions get action gact index 10
...retrieve it again and find it is gone!
sudo $TC actions get action gact index 10

Fixes: 28064b37d73c ("net_sched: convert tcf_exts from list to pointer array"),
Fixes: e63f4be61014 ("net_sched: remove an unnecessary list_del()")
Fixes: f1431ad3597b ("net_sched: remove the leftover cleanup_a()")
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_api.c