]> git.baikalelectronics.ru Git - kernel.git/commit
power: supply: ltc2941-battery-gauge: fix use-after-free
authorSven Van Asbroeck <thesven73@gmail.com>
Thu, 19 Sep 2019 15:11:37 +0000 (11:11 -0400)
committerSebastian Reichel <sre@kernel.org>
Tue, 14 Jan 2020 00:23:20 +0000 (01:23 +0100)
commit4188a38b3fb39d17eca86501e84b67f53b0a921a
tree6cb3a9621766007f62a83311086a1fa633d7a914
parent0b62e97cc0d3f99313cfa2c2129974bd43e20537
power: supply: ltc2941-battery-gauge: fix use-after-free

This driver's remove path calls cancel_delayed_work().
However, that function does not wait until the work function
finishes. This could mean that the work function is still
running after the driver's remove function has finished,
which would result in a use-after-free.

Fix by calling cancel_delayed_work_sync(), which ensures that
that the work is properly cancelled, no longer running, and
unable to re-schedule itself.

This issue was detected with the help of Coccinelle.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/ltc2941-battery-gauge.c