]> git.baikalelectronics.ru Git - kernel.git/commit
smb3: correct server pointer dereferencing check to be more consistent
authorSteve French <stfrench@microsoft.com>
Thu, 23 Sep 2021 23:52:40 +0000 (18:52 -0500)
committerSteve French <stfrench@microsoft.com>
Fri, 24 Sep 2021 02:12:23 +0000 (21:12 -0500)
commit415a33e5133e777847e1f7803c2eea12c9171ca1
tree95e0dc39a0f34e4d25883ca6f7ffcb94e9e60f94
parent4a09ea9c46d0c362327a2f73b910ef05a8d30851
smb3: correct server pointer dereferencing check to be more consistent

Address warning:

    fs/smbfs_client/misc.c:273 header_assemble()
    warn: variable dereferenced before check 'treeCon->ses->server'

Pointed out by Dan Carpenter via smatch code analysis tool

Although the check is likely unneeded, adding it makes the code
more consistent and easier to read, as the same check is
done elsewhere in the function.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/misc.c