]> git.baikalelectronics.ru Git - kernel.git/commit
xen-netback: support frontends without feature-rx-notify again
authorDavid Vrabel <david.vrabel@citrix.com>
Thu, 18 Dec 2014 11:13:06 +0000 (11:13 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 18 Dec 2014 17:49:49 +0000 (12:49 -0500)
commit4111cddd0115bc172a721c2322d80a80cf2cba1b
tree6ae75952d9356a1e82d175c67501506ad535cace
parent4dceb2881221d248ac8cc61aadab75bef6818e6a
xen-netback: support frontends without feature-rx-notify again

Commit 057b9572a512602c9303f121d5b7239148e8c4fa (xen-netback: make
feature-rx-notify mandatory) incorrectly assumed that there were no
frontends in use that did not support this feature.  But the frontend
driver in MiniOS does not and since this is used by (qemu) stubdoms,
these stopped working.

Netback sort of works as-is in this mode except:

- If there are no Rx requests and the internal Rx queue fills, only
  the drain timeout will wake the thread.  The default drain timeout
  of 10 s would give unacceptable pauses.

- If an Rx stall was detected and the internal Rx queue is drained,
  then the Rx thread would never wake.

Handle these two cases (when feature-rx-notify is disabled) by:

- Reducing the drain timeout to 30 ms.

- Disabling Rx stall detection.

Reported-by: John <jw@nuclearfallout.net>
Tested-by: John <jw@nuclearfallout.net>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netback/common.h
drivers/net/xen-netback/interface.c
drivers/net/xen-netback/netback.c
drivers/net/xen-netback/xenbus.c