]> git.baikalelectronics.ru Git - kernel.git/commit
HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges
authorEric Biggers <ebiggers@google.com>
Wed, 14 Nov 2018 21:55:09 +0000 (13:55 -0800)
committerJiri Kosina <jkosina@suse.cz>
Mon, 19 Nov 2018 13:25:15 +0000 (14:25 +0100)
commit410b0560b36a41dacfceb126349a986823e3d17f
treec9d6f98e9f9013c24985b5200728b97969fef2e3
parented0b33c52bda1b994f10a535607e794400e048ee
HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

When a UHID_CREATE command is written to the uhid char device, a
copy_from_user() is done from a user pointer embedded in the command.
When the address limit is KERNEL_DS, e.g. as is the case during
sys_sendfile(), this can read from kernel memory.  Alternatively,
information can be leaked from a setuid binary that is tricked to write
to the file descriptor.  Therefore, forbid UHID_CREATE in these cases.

No other commands in uhid_char_write() are affected by this bug and
UHID_CREATE is marked as "obsolete", so apply the restriction to
UHID_CREATE only rather than to uhid_char_write() entirely.

Thanks to Dmitry Vyukov for adding uhid definitions to syzkaller and to
Jann Horn for commit 07eadc38810ca ("x86/fault: BUG() when uaccess
helpers fault on kernel addresses"), allowing this bug to be found.

Reported-by: syzbot+72473edc9bf4eb1c6556@syzkaller.appspotmail.com
Fixes: be41adf57e16 ("HID: uhid: add UHID_CREATE and UHID_DESTROY events")
Cc: <stable@vger.kernel.org> # v3.6+
Cc: Jann Horn <jannh@google.com>
Cc: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Jann Horn <jannh@google.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/uhid.c